Improved metabase interfaces for group-addressed operations#3933
Open
roman-khimov wants to merge 3 commits intomasterfrom
Open
Improved metabase interfaces for group-addressed operations#3933roman-khimov wants to merge 3 commits intomasterfrom
roman-khimov wants to merge 3 commits intomasterfrom
Conversation
The only real user of random address lists is lancet, it can cope with that. GC is semi-dependent on this, but that's an area for improvement. Otherwise this change allows to seriously simplify some metabase logic. Fixes #3900. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
requested review from
End-rey,
carpawell and
cthulhu-rider
as code owners
We even have a test for it. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
meta-oid-slices
branch
from
1a82efb to
57c39a3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3933 +/- ##
==========================================
- Coverage 26.81% 26.77% -0.04%
==========================================
Files 677 677
Lines 44723 44711 -12
==========================================
- Hits 11992 11973 -19
- Misses 31617 31624 +7
Partials 1114 1114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify metabase internals, fix some existing and potential bugs.