dbft: specify rejected hashes on CV construction#158
Closed
AnnaShaleva wants to merge 1 commit intomasterfrom
Closed
dbft: specify rejected hashes on CV construction#158AnnaShaleva wants to merge 1 commit intomasterfrom
AnnaShaleva wants to merge 1 commit intomasterfrom
Conversation
Ref. nspcc-dev/neo-go#4148. Signed-off-by: Anna Shaleva <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 57.65% 57.72% +0.06%
==========================================
Files 33 33
Lines 1913 1916 +3
==========================================
+ Hits 1103 1106 +3
Misses 717 717
Partials 93 93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| VerifyPreBlock func(b PreBlock[H]) bool | ||
| // VerifyBlock verifies if block is valid. | ||
| VerifyBlock func(b Block[H]) bool | ||
| // VerifyBlock verifies if block is valid and optionally returns the hash of invalid transaction. |
Member
Author
There was a problem hiding this comment.
A single one. NeoGo fails verification after first invalid transaction.
Member
Author
|
Won't be included into our version of dBFT, we're fine with server-side logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. nspcc-dev/neo-go#4148.