style: fix i18n lunaria style#1737
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change wraps the existing status table in a new div with class "status-by-file-wrapper", altering only the surrounding HTML structure. Styles update several colour tokens (including Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lunaria/styles.ts (1)
178-184: Consider usingoverflow-x: autoinstead ofscroll.Using
scrollalways displays a scrollbar, even when the table fits within the viewport. Usingautowould only show the scrollbar when content overflows, providing a cleaner appearance on wider screens.♻️ Suggested change
.status-by-file-wrapper { - overflow-x: scroll; + overflow-x: auto; margin-bottom: 1rem; border: 1px solid var(--ln-color-table-border); border-radius: 0.375rem; scrollbar-color: var(--ln-color-gray-6) var(--ln-color-gray-2); }
🔗 Linked issue
Related to #1715
🧭 Context
When you navigate to https://i18n.npmx.dev/, some of the text in dark mode is too dark and not visible. The status table also overflows the layout instead of fitting within the page.
Before – Image 1
Before – Image 2
📚 Description
This PR fixes the dark mode contrast issues and the table overflow on the i18n page.
I also cleaned up some CSS that wasn’t doing anything and corrected the color variables so missing translations are clearly visible in dark mode.
Now – Image 1
Now – Video 1
Screen.Recording.2026-02-28.at.06.12.02.mov