feat(i18n): add browser locale support for formatting#1727
Draft
feat(i18n): add browser locale support for formatting#1727
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
userquin
commented
Feb 27, 2026
| const { currentLocaleStatus, isSourceLocale } = useI18nStatus() | ||
| const keyboardShortcutsEnabled = useKeyboardShortcuts() | ||
|
|
||
| const rtl = new Map<string, boolean>(locales.value.map(l => [l.code, l.dir === 'rtl'])) |
Member
Author
There was a problem hiding this comment.
don't remove this, maybe we'll need it
Override not necessary after vue-data-ui's bump to 3.15.9 (#1740)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
🧭 Context
Add support for browser locale formatting via new setting for:
📚 Description
This PR adds a new composable (
useUserLocale) to use the new settinguseSystemLocaleForFormatting(false by default, current behavior) or the app locale.This will allow use correct formatting for country variants locales where we use the generic one (ar-EG or es-419): date, datetime, size or numbers can vary (decimal separator, thousand separator, date formats can change some style => es-CO and es-ES dates with short style for example)
TODO:
package.size.b,package.size.kandpackage.size.mapp/components/Package/WeeklyDownloadStats.vue: we need to check VueUi RTL support (flex-start)