Skip to content

feat(i18n): add missing German translations and pluralization#1720

Merged
danielroe merged 7 commits intonpmx-dev:mainfrom
tomvoet:feat/i18n/add_missing_german_translations
Mar 1, 2026
Merged

feat(i18n): add missing German translations and pluralization#1720
danielroe merged 7 commits intonpmx-dev:mainfrom
tomvoet:feat/i18n/add_missing_german_translations

Conversation

@tomvoet
Copy link
Contributor

@tomvoet tomvoet commented Feb 27, 2026

📚 Description

  • Added all missing german translations
  • Improved download trends y-label translation
  • Added pluralization to files_count, lines_hidden, and deps_count
  • Added a title and small-screen-sr-only to the diff button on the package page, to match the other buttons

The pluralization fixes and especially the diff button change go slightly beyond i18n. I'd be happy to split them into a separate PR if that's preferred.

@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Mar 1, 2026 0:40am
npmx.dev Ready Ready Preview, Comment Mar 1, 2026 0:40am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Mar 1, 2026 0:40am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/de-DE.json Localization changed, will be marked as complete. 🔄️
lunaria/files/en-GB.json Localization changed, will be marked as complete. 🔄️
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7896b2a and f3a4556.

📒 Files selected for processing (5)
  • app/pages/package/[[org]]/[name].vue
  • i18n/locales/en.json
  • i18n/schema.json
  • lunaria/files/en-GB.json
  • lunaria/files/en-US.json
🚧 Files skipped from review as they are similar to previous changes (4)
  • lunaria/files/en-US.json
  • app/pages/package/[[org]]/[name].vue
  • lunaria/files/en-GB.json
  • i18n/locales/en.json

📝 Walkthrough

Walkthrough

Translation calls in several Vue components (MobileSidebarDrawer.vue, SidebarPanel.vue, SkipBlock.vue, diff and package pages) now pass explicit numeric counts as a third argument to i18n/$t calls to enable pluralisation; the package page link also binds a translated title and adds a screen-reader-only label for small viewports. Locale files (en, en-GB, en-US, de-DE and lunaria variants) add pluralised forms and a new compare_versions_title key. i18n/schema.json adds compare_versions_title. No exported API signatures were changed.

Possibly related PRs

Suggested reviewers

  • danielroe
  • trueberryless
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, detailing German translations, pluralization improvements, and UI enhancements to the diff button.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/package/[[org]]/[name].vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@danielroe danielroe requested a review from userquin February 28, 2026 08:40
Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielroe danielroe added this pull request to the merge queue Mar 1, 2026
Merged via the queue into npmx-dev:main with commit d87be52 Mar 1, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants