[IDEA] allow server to add ShakeEffectValues on players

[killjsj]

Goal Description

Basically, allow custom ShakeEffectValues to be applied to players through something like a NetworkMessage, rpc effect or anything,of course there will have very likely lead to stupid sync in every frame, but that is probably necessary for anims,this would make things like server-side playback of advanced camera animations possible, like to what FilmmakerRole does, or even things like a third-person camera

Notes

btw use id and accumulate every shakes or plugins will fight for cam control

[killjsj]

trying to write a example:

using CameraShaking;
using Mirror;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using UnityEngine;
using Utils.Networking;
using Utils.NonAllocLINQ;

public struct SSCameraShakeUpdateMessage : NetworkMessage
{
    public uint Id;
    public ShakeEffectValues ShakeEffect;
    public float Duration;
}

public struct SSCameraShakeRemoveMessage : NetworkMessage
{
    public uint Id;
}
//stupid way -> sync every frame
public class SSCameraShakeEffect : IShakeEffect, IEquatable<SSCameraShakeEffect>
{
    public uint id;

    public ShakeEffectValues shakeEffect = ShakeEffectValues.None;

    public float StopTime;

    public float dur;
    bool IShakeEffect.GetEffect(
        ReferenceHub ply,
        out ShakeEffectValues shakeValues)
    {
        shakeValues = shakeEffect;

        if (StopTime == 0f)
            return true;

        return Time.time <= StopTime;
    }

    public bool Equals(SSCameraShakeEffect other)
    {
        return other != null && id == other.id;
    }

    public override bool Equals(object obj)
    {
        return obj is SSCameraShakeEffect other && Equals(other);
    }

    public override int GetHashCode()
    {
        return id.GetHashCode();
    }
}
public class SSCameraShakeManager : NetworkBehaviour // this mount on refhub
{
    private static SSCameraShakeManager local;

    public uint cid = 1;

    private readonly Dictionary<uint, SSCameraShakeEffect> sseffects
        = new Dictionary<uint, SSCameraShakeEffect>();
    private List<uint> remove = new();

    public void Update()
    {
        if (isServer)
        {
            remove.Clear();
            foreach (var effect in sseffects)
            {
                if (effect.Value.StopTime <= Time.time && effect.Value.StopTime != 0)
                {
                    remove.Add(effect.Key);
                }
            }
            foreach (var item in remove)
            {
                sseffects.Remove(item);
            }
        }
    }

    public override void OnStartClient()
    {
        base.OnStartClient();

        if (isLocalPlayer)
            local = this;
    }

    public override void OnStopClient()
    {
        if (local == this)
            local = null;

        base.OnStopClient();
    }

    public static void RegisterMessages()
    {
        NetworkClient.RegisterHandler<SSCameraShakeUpdateMessage>(
            OnShakeUpdateMessage);

        NetworkClient.RegisterHandler<SSCameraShakeRemoveMessage>(
            OnShakeRemoveMessage);
    }

    private static void OnShakeUpdateMessage(
        SSCameraShakeUpdateMessage msg)
    {
        local?.ClientAddOrModifySSCamShake(
            msg.Id,
            msg.ShakeEffect,
            msg.Duration);
    }

    private static void OnShakeRemoveMessage(
        SSCameraShakeRemoveMessage msg)
    {
        local?.ClientRemoveSSCamShake(msg.Id);
    }
    [Client]
    public void ClientAddOrModifySSCamShake(
uint id,
ShakeEffectValues shakeEffect,
float duration)
    {
        if (sseffects.TryGetValue(id, out var effect))
        {
            effect.shakeEffect = shakeEffect;
            effect.dur = duration;

            effect.StopTime =
                duration <= 0f
                    ? 0f
                    : Time.time + duration;

            return;
        }

        var newEffect = new SSCameraShakeEffect
        {
            id = id,
            shakeEffect = shakeEffect,
            dur = duration,
            StopTime = duration <= 0f
                ? 0f
                : Time.time + duration
        };

        sseffects.Add(id, newEffect);

        CameraShakeController.AddEffect(newEffect);
    }
    [Client]
    public bool ClientRemoveSSCamShake(uint id)
    {
        if (!sseffects.TryGetValue(id, out var effect))
            return false;

        effect.StopTime = Time.time;
        sseffects.Remove(id);

        return true;
    }
    [Server]
    public bool ServerRemoveSSCamShake(
        ReferenceHub hub,
        uint id)
    {
        if (!sseffects.Remove(id))
            return false;

        new SSCameraShakeRemoveMessage
        {
            Id = id
        }.SendToHubsConditionally(x => x == hub);

        return true;
    }
    [Server]
    public bool ServerModifySSCamShake(
ReferenceHub hub,
uint id,
ShakeEffectValues? newValues = null,
float? newDur = null,
bool addDuration = false)
    {
        if (!sseffects.TryGetValue(id, out var effect))
            return false;

        if (effect.StopTime != 0f &&
            effect.StopTime <= Time.time)
        {
            sseffects.Remove(id);
            return false;
        }

        if (newValues.HasValue)
            effect.shakeEffect = newValues.Value;

        if (newDur.HasValue)
        {
            if (addDuration)
            {
                if (effect.StopTime == 0f)
                {
                    effect.dur = 0f;
                    effect.StopTime = 0f;
                }
                else
                {
                    float remaining =
                        Mathf.Max(0f, effect.StopTime - Time.time);

                    effect.dur = remaining + newDur.Value;

                    effect.StopTime =
                        effect.dur <= 0f
                            ? 0f
                            : Time.time + effect.dur;
                }
            }
            else
            {
                effect.dur = newDur.Value;

                effect.StopTime =
                    effect.dur <= 0f
                        ? 0f
                        : Time.time + effect.dur;
            }
        }

        new SSCameraShakeUpdateMessage
        {
            Id = effect.id,
            ShakeEffect = effect.shakeEffect,
            Duration = effect.dur
        }.SendToHubsConditionally(x => x == hub);

        return true;
    }
}

PLEASED NW PLEASE

[killjsj]

wait the code doesnt have add.in server's code
im going to sleep so I will change it tomorrow

[killjsj]

new

using CameraShaking;
using Google.Protobuf.WellKnownTypes;
using Mirror;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using UnityEngine;
using Utils.Networking;
using Utils.NonAllocLINQ;

public struct SSCameraShakeUpdateMessage : NetworkMessage
{
    public uint Id;
    public ShakeEffectValues ShakeEffect;
    public float Duration;
}

public struct SSCameraShakeRemoveMessage : NetworkMessage
{
    public uint Id;
}
//stupid way -> sync every frame
public class SSCameraShakeEffect : IShakeEffect, IEquatable<SSCameraShakeEffect>
{
    public uint id;

    public ShakeEffectValues shakeEffect = ShakeEffectValues.None;

    public float StopTime;

    public float dur;
    bool IShakeEffect.GetEffect(
        ReferenceHub ply,
        out ShakeEffectValues shakeValues)
    {
        shakeValues = shakeEffect;

        if (StopTime == 0f)
            return true;

        return Time.time <= StopTime;
    }

    public bool Equals(SSCameraShakeEffect other)
    {
        return other != null && id == other.id;
    }

    public override bool Equals(object obj)
    {
        return obj is SSCameraShakeEffect other && Equals(other);
    }

    public override int GetHashCode()
    {
        return id.GetHashCode();
    }
}
public class SSCameraShakeManager : NetworkBehaviour // this mount on refhub
{
    private static SSCameraShakeManager local;

    public uint cid = 1;

    private readonly Dictionary<uint, SSCameraShakeEffect> sseffects
        = new Dictionary<uint, SSCameraShakeEffect>();
    private List<uint> remove = new();

    public void Update()
    {
        if (isServer)
        {
            remove.Clear();
            foreach (var effect in sseffects)
            {
                if (effect.Value.StopTime <= Time.time && effect.Value.StopTime != 0)
                {
                    remove.Add(effect.Key);
                }
            }
            foreach (var item in remove)
            {
                sseffects.Remove(item);
            }
        }
    }

    public override void OnStartClient()
    {
        base.OnStartClient();

        if (isLocalPlayer)
            local = this;
    }

    public override void OnStopClient()
    {
        if (local == this)
            local = null;

        base.OnStopClient();
    }

    public static void RegisterMessages()
    {
        NetworkClient.RegisterHandler<SSCameraShakeUpdateMessage>(
            OnShakeUpdateMessage);

        NetworkClient.RegisterHandler<SSCameraShakeRemoveMessage>(
            OnShakeRemoveMessage);
    }

    private static void OnShakeUpdateMessage(
        SSCameraShakeUpdateMessage msg)
    {
        local?.ClientAddOrModifySSCamShake(
            msg.Id,
            msg.ShakeEffect,
            msg.Duration);
    }

    private static void OnShakeRemoveMessage(
        SSCameraShakeRemoveMessage msg)
    {
        local?.ClientRemoveSSCamShake(msg.Id);
    }
    [Client]
    public void ClientAddOrModifySSCamShake(
uint id,
ShakeEffectValues shakeEffect,
float duration)
    {
        if (sseffects.TryGetValue(id, out var effect))
        {
            effect.shakeEffect = shakeEffect;
            effect.dur = duration;

            effect.StopTime =
                duration <= 0f
                    ? 0f
                    : Time.time + duration;

            return;
        }

        var newEffect = new SSCameraShakeEffect
        {
            id = id,
            shakeEffect = shakeEffect,
            dur = duration,
            StopTime = duration <= 0f
                ? 0f
                : Time.time + duration
        };

        sseffects.Add(id, newEffect);

        CameraShakeController.AddEffect(newEffect);
    }
    [Client]
    public bool ClientRemoveSSCamShake(uint id)
    {
        if (!sseffects.TryGetValue(id, out var effect))
            return false;

        effect.StopTime = Time.time;
        sseffects.Remove(id);

        return true;
    }
    [Server]
    public bool ServerModifyOrAddSSCamShake(
ReferenceHub hub,
uint id,
ShakeEffectValues? newValues = null,
float? newDur = null,
bool addDuration = false)
    {
        if (!sseffects.TryGetValue(id, out var effect))
        {

            effect = new SSCameraShakeEffect
            {
                id = id,
                shakeEffect = newValues??ShakeEffectValues.None,
                dur = newDur ?? 0f,
                StopTime = (newDur ?? 0f) <= 0f ? 0f : Time.time + (newDur ?? 0f)
            };

            sseffects.Add(id, effect);

            new SSCameraShakeUpdateMessage
            {
                Id = effect.id,
                ShakeEffect = effect.shakeEffect,
                Duration = effect.dur
            }.SendToHubsConditionally(x => x == hub);

            return true;
        }

        if (effect.StopTime != 0f &&
            effect.StopTime <= Time.time)
        {
            sseffects.Remove(id);
            return false;
        }

        if (newValues.HasValue)
            effect.shakeEffect = newValues.Value;

        if (newDur.HasValue)
        {
            if (addDuration)
            {
                if (effect.StopTime == 0f)
                {
                    effect.dur = 0f;
                    effect.StopTime = 0f;
                }
                else
                {
                    float remaining =
                        Mathf.Max(0f, effect.StopTime - Time.time);

                    effect.dur = remaining + newDur.Value;

                    effect.StopTime =
                        effect.dur <= 0f
                            ? 0f
                            : Time.time + effect.dur;
                }
            }
            else
            {
                effect.dur = newDur.Value;

                effect.StopTime =
                    effect.dur <= 0f
                        ? 0f
                        : Time.time + effect.dur;
            }
        }

        new SSCameraShakeUpdateMessage
        {
            Id = effect.id,
            ShakeEffect = effect.shakeEffect,
            Duration = effect.dur
        }.SendToHubsConditionally(x => x == hub);

        return true;
    }
}