ptz: Move backend-specific code to each backend#167
Merged
Conversation
The control ranges depend on the model. Hence, the properties should be provided by each backend. The plugin obs-ptz assumes SRG-120DH so that the ranges can be fixed values.
norihiro
force-pushed
the
move-to-ptz-backend
branch
from
145a3c7 to
8309b4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The device-specific implementations for settings and properties were written in
src/face-tracker-ptz.cpp. This makes difficult to maintain or add more device types.This PR moves the code to each source file of the backend device.
The modification is separated from #161.
How Has This Been Tested?
General checklist