Repository navigation
Conversation
Keep the contribution current with upstream while retaining its published ancestry.
…178-upstream-20261008 # Conflicts: # Demo/MarkdownEngineDemo/ContentView.swift
Contributor
Author
|
Maintainer update: the branch is current through upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A common embedding shows a note read-only and still lets the user tick its checklist, like the preview in most notes apps. With
isEditable = falsethe checkbox click is rejected byshouldChangeText, so today that requires making the whole editor editable.What changes
allowsTaskCheckboxInteractionWhenReadOnly: Bool(defaultfalse). When it is on:[ ]/[x]as one undoable edit;The opt-in native checkbox behavior remains the complete scope of this PR. It does not introduce the separate A2 host-decided activation direction.
This update merges
upstream/mainat7c626334d2e87146b0c34e340af3b9bb37a3ba81with the published topic ancestry intact; the demo conflict retained both the checkbox opt-in and upstream directive completion demo.Tests
ReadOnlyTaskCheckboxTestscovers the default staying off, the opt-in click toggling the binding while ordinary edits stay blocked, the exact three-character mutation, and undo/redo. Fullswift test --no-parallelpassed 589 core tests in 76 suites and 1 LaTeX test.The separate host-decided activation proposal remains outside this PR.