-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
test_runner: fix lazy test.assert accessor
#61097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
Renegade334:test-runner-assert-accessor
Dec 20, 2025
Merged
test_runner: fix lazy test.assert accessor
#61097
nodejs-github-bot
merged 1 commit into
nodejs:main
from
Renegade334:test-runner-assert-accessor
Dec 20, 2025
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
8d0928a to
deb3808
Compare
test.assert accessortest.assert accessor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61097 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 703 703
Lines 208546 208550 +4
Branches 40217 40212 -5
=======================================
+ Hits 184634 184638 +4
+ Misses 15926 15921 -5
- Partials 7986 7991 +5
🚀 New features to boost your workflow:
|
targos
approved these changes
Dec 18, 2025
pmarchini
approved these changes
Dec 18, 2025
JakobJingleheimer
approved these changes
Dec 19, 2025
Collaborator
avivkeller
approved these changes
Dec 19, 2025
Collaborator
Collaborator
|
Landed in 3b7477c |
MatricalDefunkt
pushed a commit
to MatricalDefunkt/node
that referenced
this pull request
Dec 22, 2025
PR-URL: nodejs#61097 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Aviv Keller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention was for this to be a define-on-access lazy property, but the object passed to
Object.definePropertyisn't a descriptor, so this never happens. As a result, theassertobject is currently reconstructed on every access;test.assert === test.assertis false at present.Changed to a conventional lazy getter, in alignment with the other
node:testproperty accessors.