Skip to content

Conversation

@computerscienceiscool
Copy link
Contributor

fix broken GitHub profile link for Node.js contributor

Replace outdated profile URL (DavidCai1993) with current URL (DavidCai1111). The previous link was returning 404. New profile confirmed as Node.js contributor.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 17, 2025
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avivkeller
Copy link
Member

Hi @computerscienceiscool! Can you please amend your commit to follow our guidelines?

Something like doc: correct invalid collaborator profile would do.

Thank you!

@computerscienceiscool computerscienceiscool changed the title Update README.md doc: correct invalid collaborator profile Dec 18, 2025
@avivkeller
Copy link
Member

Hey again, @computerscienceiscool! Unfortunately, changing the PR title isn't enough. You need to amend the commit message of your first comment.

@computerscienceiscool
Copy link
Contributor Author

I was away from my computer and I just updated. Thanks.

@avivkeller
Copy link
Member

cc @DavidCai1111

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5ea56f4 into nodejs:main Dec 20, 2025
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5ea56f4

MatricalDefunkt pushed a commit to MatricalDefunkt/node that referenced this pull request Dec 22, 2025
PR-URL: nodejs#61091
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants