assert,util: improve deep comparison performance #61076
Closed
+111
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
aduh95
reviewed
Dec 15, 2025
aduh95
reviewed
Dec 15, 2025
BridgeAR
force-pushed
the
BridgeAR/2025-12-14-improve-assert-perf
branch
from
4f7303b to
641e674
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61076 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 703 703
Lines 208588 208574 -14
Branches 40233 40224 -9
=======================================
+ Hits 184666 184668 +2
+ Misses 15942 15913 -29
- Partials 7980 7993 +13
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Dec 16, 2025
ljharb
reviewed
Dec 17, 2025
anonrig
approved these changes
Dec 18, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
aduh95
requested changes
Dec 20, 2025
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Adding request for changes so this doesn't land before the --no-js_float16array runtime flag is removed. Alternatively, we could remove it from this PR as this has little to do with performance.
Member
Author
|
@aduh95 I am not following why we have to wait for it to be removed. We definitely ship with the support and removing that won't happen. I think we can absolutely land this as is. |
Contributor
We ship with both support and lack there of, it's a runtime flag.
I think we can absolutely wait, there's no rush, is there? |
The property comparison of invalid dates regressed when starting to handle invalid dates as being equal.
This is a very small improvement for error creation.
BridgeAR
force-pushed
the
BridgeAR/2025-12-14-improve-assert-perf
branch
from
641e674 to
645d056
Compare
BridgeAR
added
the
commit-queue-rebase
aduh95
approved these changes
Dec 22, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
BridgeAR
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 416db75...6157c81 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
PR-URL: #61076 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
The property comparison of invalid dates regressed when starting to handle invalid dates as being equal. PR-URL: #61076 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
This is a very small improvement for error creation. PR-URL: #61076 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines minor performance improvements for edge cases as well as adding more tests for partialDeepStrictEqual, resolving a TODO, and fixing a bug while comparing invalid dates (not taking into account that extra properties might exist).
The performance gain is mostly for objects containing symbols. We do not have benchmarks for these and our current benchmarks will not show much difference.
See commit messages for details.