Skip to content

[v20.x] test: skip test-http-imports on macos#59745

Closed
marco-ippolito wants to merge 1 commit intov20.x-stagingfrom
skip-flake
Closed

[v20.x] test: skip test-http-imports on macos#59745
marco-ippolito wants to merge 1 commit intov20.x-stagingfrom
skip-flake

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Sep 3, 2025

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Sep 3, 2025
@marco-ippolito marco-ippolito mentioned this pull request Sep 3, 2025
Merged
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69022/

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69023/

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 3, 2025
@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 3, 2025
@aduh95
Copy link
Contributor

aduh95 commented Sep 3, 2025 •
edited
Loading

commit-queue Add this label to land a pull request using GitHub Actions. only works on PRs targeting main

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Sep 3, 2025

commit-queue Add this label to land a pull request using GitHub Actions. only works on PR targeting main

force of habit 💀

marco-ippolito added a commit that referenced this pull request Sep 3, 2025
@marco-ippolito
test: skip test-http-imports on macos
5e97719 
PR-URL: #59745
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
@marco-ippolito
Copy link
Member Author

marco-ippolito commented Sep 3, 2025

Landed in 5e97719

@aduh95 aduh95 deleted the skip-flake branch September 3, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

@pmarchini pmarchini pmarchini approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marco-ippolito @nodejs-github-bot @aduh95 @pmarchini