Repository navigation
fix: hide tag names and shelf contents of copies a reader can't see - #9
Merged
Merged
Conversation
A tag name or a shelf's contents can reveal what a hidden copy is, so neither should be visible to someone who can't see the copy. - List a library's tags only if they are on a copy the reader can see. A tag on no copy, left behind by a re-tag or a delete, is listed only to those who could see every copy it might have been on. - Make removing a copy from a shelf answer the same for a hidden copy as for one that isn't there. Assisted-by: Claude Code Signed-off-by: Natalie Boedecker <git@boedecker.dev>
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A tag name or a shelf's contents can reveal what a hidden copy is, so neither should be visible to someone who can't see the copy. This closes two places where they could be.
This is the fix half of the tags and shelves work in #8. It is independent of the pages there and passes every check without them, so it can merge first.
Not in this PR
DELETE /api/v1/tags/{id}lets an editor delete a tag that only hidden copies use.Checklist
CHANGELOG.mdhas a line underUnreleased, or this change isn't user-visible.Signed-off-byline.Breaking changes
None.
GET /api/v1/libraries/{id}/tagsnow returns fewer rows to readers who can't see some copies, which is the privacy fix above.Security-sensitive areas
AI assistance
Claude Code wrote this change and its tests. An advisor review ran before it was presented, and it found both gaps in my first version of the tag filter and the shelf removal. The maintainer reviewed and made the commit.