Skip to content

feat(navbar): confirm before logout to prevent accidental logouts#110

Open
sricharan12-hub wants to merge 1 commit into
niharika-mente:mainfrom
sricharan12-hub:fix/logout-confirmation-modal
Open

feat(navbar): confirm before logout to prevent accidental logouts#110
sricharan12-hub wants to merge 1 commit into
niharika-mente:mainfrom
sricharan12-hub:fix/logout-confirmation-modal

Conversation

@sricharan12-hub

Copy link
Copy Markdown

Overview

Adds a confirmation step before logout so a stray or mis-aimed click can no longer
end the session instantly.

Closes #78

Changes

In frontend/src/components/Navbar.jsx:

  • The Logout button now opens a confirmation modal (tracked with useState)
    instead of calling logout() directly.
  • The modal shows a clear message and two actions — Cancel (closes, no change)
    and Logout (proceeds). logout() runs only on confirm.
  • Dismissable via Cancel, the close (X) button, clicking the backdrop,
    and the Esc key (keydown listener registered only while the modal is open).
  • Styled with the existing Tailwind conventions, including light/dark mode; the
    dialog uses role="dialog" / aria-modal and is labelled for accessibility.

Acceptance criteria

  • Clicking Logout shows a confirmation modal before the session ends.
  • Clear message with Cancel and Logout actions.
  • logout() is only called when the user confirms.
  • Dismissable via Cancel, close button, backdrop, and Esc.
  • Matches existing UI styling (Tailwind, light/dark).

Testing

  • eslint passes on Navbar.jsx.
  • Confirmed logout() in AuthContext takes no arguments, so calling it from the
    modal's confirm handler is equivalent to the previous onClick={logout}.

The Logout button ended the session on a single click, so a stray click
logged the user out with no chance to cancel.

- Logout now opens a confirmation modal instead of calling logout()
  directly; the session ends only when the user confirms.
- The modal is dismissable via Cancel, the close (X) button, clicking the
  backdrop, and the Esc key, and matches the existing Tailwind light/dark
  styling.

Closes niharika-mente#78
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@sricharan12-hub, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3e0f9ee7-8189-4fc4-8bc4-398a8afd64e5

📥 Commits

Reviewing files that changed from the base of the PR and between 87148ba and bfffbdb.

📒 Files selected for processing (1)
  • frontend/src/components/Navbar.jsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a confirmation modal before logout to prevent accidental logout

1 participant