Skip to content

Remove unused variable #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gin-ahirsch wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unused variable #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
693a1a9
Remove unused variable
gin-ahirsch Mar 1, 2019
8ffd97d
Don't include unused header
gin-ahirsch Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/data/logfiltereddata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include "log.h"

#include <QString>
#include <cassert>
#include <limits>

#include "utils.h"
Expand All @@ -45,7 +44,6 @@ LogFilteredData::LogFilteredData() : AbstractLogData(),
/* Prevent any more searching */
maxLength_ = 0;
maxLengthMarks_ = 0;
searchDone_ = true;
visibility_ = MarksAndMatches;

filteredItemsCacheDirty_ = true;
Expand All @@ -68,8 +66,6 @@ LogFilteredData::LogFilteredData( const LogData* logData )

sourceLogData_ = logData;

searchDone_ = false;

visibility_ = MarksAndMatches;

filteredItemsCacheDirty_ = true;
Expand Down Expand Up @@ -280,7 +276,6 @@ void LogFilteredData::handleSearchProgressed( int nbMatches, int progress, qint6
LOG(logDEBUG) << "LogFilteredData::handleSearchProgressed matches="
<< nbMatches << " progress=" << progress;

// searchDone_ = true;
workerThread_.getSearchResult( &maxLength_, &matching_lines_, &nbLinesProcessed_ );
filteredItemsCacheDirty_ = true;

Expand Down
1 change: 0 additions & 1 deletion src/data/logfiltereddata.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ class LogFilteredData : public AbstractLogData {

const LogData* sourceLogData_;
QRegularExpression currentRegExp_;
bool searchDone_;
int maxLength_;
int maxLengthMarks_;
// Number of lines of the LogData that has been searched for:
Expand Down