New Complex Impedance Measurement plug-in. - #14
Conversation
|
Squash merge this when it goes in |
| REM You can customize this script for your Python setup. The -v option logs | ||
| REM messages with level INFO and above. | ||
|
|
||
| .venv\Scripts\python.exe measurement.py -v |
There was a problem hiding this comment.
This assumes the user has a python virtual environment in the directory named ".venv" of whatever directory they happen to be in when they call the script.
Let's get rid of the .venv\Scripts\ piece and just call python.exe "%~dp0/measurement.py" -v
There was a problem hiding this comment.
If you're going to include the .measproj and .measui files, then you should get them to work in InstrumentStudio or the Measurement Plug-In UI Editor
FlexLogger doesn't use those files at all and I believe you can safely delete them completely if we want.
Seems like this could be a useful plugin for InstrumentStudio, too, though. Should we maybe talk to somebody on InstrumentStudio and see if we want to put Measurement plugins in some other repo that's more obviously applicable to both FlexLogger & InstrumentStudio (& whatever else exposes Measurement plugins in the future)?
|
|
||
| - Click Done. | ||
|
|
||
|  |
There was a problem hiding this comment.
Waterfall.jpg -> ComplexImpedance.jpg
|
|
||
| ## Getting Started | ||
|
|
||
| - Make sure the system has the recommended Python version installed. Install Measurement Plug-In SDK for Python using [pip](https://pip.pypa.io/). |
There was a problem hiding this comment.
It's not clear what requirements need to be installed.
Just running start.bat from a fresh new venv, I get "need to install click" and then "need to install numpy".
Add a requirements.txt file for the pip requirements & update the readme.
I think I needed these requirements:
click
numpy
ni-measurement-plugin-sdk
2 participants
What does this Pull Request accomplish?
A customer requested a measurement plug-in to compute the complex impedance.
Why should this Pull Request be merged?
No proprietary IP and the plug-in would be valuable for a lot of customers.
What testing has been done?
Verified the plugin works.