Repository navigation
Fix dashboard DOM XSS findings - #73
Closed
MIpetrov-NI wants to merge 3 commits into
Closed
MIpetrov-NI wants to merge 3 commits into
MIpetrov-NI wants to merge 3 commits into
Conversation
Replace HTML-string rendering in dashboard status and progress flows with safe DOM nodes, validate generated navigation URLs, and keep the canonical and bundled page copies synchronized. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const showDashLink = () => { | ||
| const dl = $("insDashLink"); | ||
| if (dl) { dl.href = url; dl.innerHTML = "Open your dashboard ↗"; dl.style.display = ""; } | ||
| if (dl) { dl.href = url; dl.textContent = "Open your dashboard \u2197"; dl.style.display = ""; } |
| const showDashLink = () => { | ||
| const dl = $("insDashLink"); | ||
| if (dl) { dl.href = url; dl.innerHTML = "Open your dashboard ↗"; dl.style.display = ""; } | ||
| if (dl) { dl.href = url; dl.textContent = "Open your dashboard \u2197"; dl.style.display = ""; } |
Build dynamic installation-summary list items with DOM nodes instead of HTML strings so setup values remain text. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| location.id = "insLiveUrl"; | ||
| if (live) { | ||
| const link = document.createElement("a"); | ||
| link.href = url; |
| location.id = "insLiveUrl"; | ||
| if (live) { | ||
| const link = document.createElement("a"); | ||
| link.href = url; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/pagesand bundledactions/dashboardassetsValidation
git diff --check