Fgumi initial commit#165
Open
freerkvandijk wants to merge 27 commits intodevfrom
Open
Conversation
v2.0.6 Release PR
- module updates - faster bclconvert output handling - modified output structure, featuring qc reports per library and enhanced run QC - fastq output when aligner equals false, with falco report - per sample analysis definition for more flexibility
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 7, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 8, 2026
matthdsm
reviewed
Apr 10, 2026
matthdsm
reviewed
Apr 10, 2026
Member
|
Still need to fix the tests |
Author
flowchart TD
A["Input channel: meta + reads + aligner + index + fasta + gtf"] --> B{sample_type}
B -->|RNA| R1[FASTQ_ALIGN_RNA]
B -->|DNA| C{"meta.fgumi_aware == true"}
C -->|false| D1["FASTQ_ALIGN_DNA non-UMI"]
C -->|true| U0[Enter UMI_CONSENSUS_FGUMI]
subgraph UMI_CONSENSUS_FGUMI
U1["Step 1: FGUMI_EXTRACT<br/>reads -> unmapped BAM with UMI tags"]
U1J["Join with reference assets<br/>SNAP index + fasta + dict from meta.genome_data"]
U2["Step 3: FGUMI_SNAP_ZIPPER_SORT"]
U2a["samtools sort -n<br/>unmapped BAM"]
U2b[fgumi fastq]
U2c[snap-aligner paired]
U2d["samtools sort -n<br/>post-SNAP"]
U2e[fgumi zipper]
U2f["fgumi sort --order template-coordinate"]
U3["Step 4: FGUMI_GROUP"]
U4["Step 5: FGUMI_SIMPLEX"]
U5J["Join simplex BAM with fasta"]
U5["Step 7a: FGUMI_FILTER"]
U6["Step 7b: FGUMI_SORT<br/>coordinate sort + index"]
U1 --> U1J --> U2
U2 --> U2a --> U2b --> U2c --> U2d --> U2e --> U2f
U2f --> U3 --> U4 --> U5J --> U5 --> U6
end
D1 --> M1["Markdup branch selector<br/>bamsormadup | samtools | sort"]
R1 --> M1
U6 --> MIX1[Mix UMI BAM/BAI into common postprocess stream]
U3 --> MET1[grouping_metrics]
U3 --> MET2[family_size_histogram]
U4 --> MET3[consensus_metrics]
U5 --> MET4[filtering_metrics]
U6 --> MET5[filtered_consensus_bam]
M1 --> P1["BIOBAMBAM_BAMSORMADUP or SAMTOOLS_SORMADUP or SAMTOOLS_SORT"]
P1 --> COMP{bam or cram}
MIX1 --> COMP
COMP -->|bam| CVT[SAMTOOLS_CONVERT to CRAM]
COMP -->|cram| OUT1["cram + crai"]
CVT --> OUT1
OUT1 --> E1["emit: cram_crai"]
MET1 --> E2["emit: sormadup_metrics"]
MET2["emit: family_size_histogram"] --> E3
MET5 --> E4["emit: filtered_consensus_bam"]
|
Member
|
comments:
|
matthdsm
reviewed
Apr 23, 2026
| ext.args = { | ||
| [ | ||
| "--sample \"${meta.id}\"", | ||
| "--library \"${meta.library ?: meta.id}\"", |
Member
There was a problem hiding this comment.
make sure all the RG info is encoded in the uBam so we don't lose any info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).