feat(design): add optional Atlas Cloud logo provider - #447
Merged
clark-cant merged 1 commit intoAug 27, 2026
Merged
clark-cant merged 1 commit into
clark-cant merged 1 commit into
Conversation
Signed-off-by: binyangzhu000-sudo <224954946+binyangzhu000-sudo@users.noreply.github.com>
clark-cant
approved these changes
Aug 27, 2026
clark-cant
left a comment
Contributor
There was a problem hiding this comment.
LGTM — solid contribution. Atlas Cloud integration is well-structured with proper security measures (SSRF-safe redirects, public URL validation, credential-free media downloads), comprehensive offline contract tests, and clean backward compatibility (Gemini remains default).
Approved findings:
- Security: SSRF protection on redirects and media download is correctly implemented
- Tests: Contract tests cover polling, timeout, retry, and API key isolation
- Docs: SKILL.md, references, and CLI help all updated consistently
- Code quality: Proper error handling, type hints, clean provider abstraction
Note for maintainers: No CI checks are configured on this repository — the validation evidence in the PR body (pytest 219 passed, npm verify/typecheck/build) was self-reported. Consider adding CI to verify future PRs automatically.
Reviewed by github-maintain cron
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds Atlas Cloud as an explicit opt-in provider for the logo generator while preserving Gemini as the default. The integration uses the asynchronous image API with a single generation POST, bounded result polling, HTTPS media validation, credential-free downloads, CLI flags, documentation, and offline contract tests.
Why?
Users with an Atlas Cloud key can generate logo variants without installing the Gemini SDK, while existing Gemini workflows and defaults remain unchanged.
Validation
python3 -m pytest .claude/skills -q(219 passed)npm run verify:datanpm run typechecknpm run buildcompleted; the no-credential media downloader was separately verified with a live Atlas-hosted PNGChecklist
.claude/skills/design/, the source of truth for bundled design sub-skillsnpm run sync:assets && npm run check:assetsincli/.claude/skills/design/scripts/logo/tests/main