feat(design-system): add Andritz design philosophy reference - #249
Conversation
Add "The Monolithic Engine" creative north star document that guides all design decisions for the Andritz Precision design system, covering tonal architecture, typography scale, elevation rules, and industrial aesthetics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Cron-safe maintain review: deferring this PR for now rather than merging the standalone philosophy file. Evidence checked:
Decision: deferred / needs consolidation. Next step: please consolidate this into the chosen Andritz implementation path (prefer a narrow source-of-truth PR, or clearly supersede this with #320 if that separate skill is the intended direction). Once the owner picks the lane, this standalone PR should be retargeted or closed to avoid parallel docs drifting. |
mrgoonie
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I’m requesting changes because this adds a new design-system reference that is currently not wired into the skill and it introduces token names/values that do not match the existing token docs.
Required changes:
- Link the new reference from
.claude/skills/design-system/SKILL.mdin the References table. Right now agents loading the design-system skill read the SKILL.md reference list, and this newreferences/design-philosophy.mdfile is not discoverable from that flow. - Align the token language with the current design-system token architecture, or add the missing token definitions as part of the same PR. The new doc references
surface,surface-container-*,primary,primary-container,on-surface-variant,outline-variant, andon-secondary-fixed, but the existing semantic/primitive token docs in this repo define the current blue/gray CSS-variable model (--color-primary,--color-card,--color-muted,--color-border, etc.). As written, this creates a parallel token vocabulary that consumers cannot validate against the current design-system references. - Either remove the unchecked test-plan claims or include a concrete verification step. The PR body says token values should be confirmed against existing semantic/primitive token references, but the added values do not currently appear in those references.
Evidence checked:
- Diff is a single new file:
.claude/skills/design-system/references/design-philosophy.md. .claude/skills/design-system/SKILL.mdReferences table does not include the new file.- Existing
references/semantic-tokens.mdandreferences/primitive-tokens.mduse the repo’s current CSS-variable naming; the new Material-style surface/on-* token names are not defined there. - Duplicate/prior-work search found related open Andritz PRs (#248, #251, #255), but no exact merged duplicate of this reference doc.
This can be a useful design direction doc, but it needs to be discoverable and token-compatible before merge.
Summary
.claude/skills/design-system/references/design-philosophy.mdTest plan
🤖 Generated with Claude Code