Skip to content

Update MiniMax music generation handling - #1522

Open
octo-patch wants to merge 1 commit into
nextlevelbuilder:devfrom
octo-patch:octo/20260823-music-generation-recvsf4VGQpexP
Open

Update MiniMax music generation handling#1522
octo-patch wants to merge 1 commit into
nextlevelbuilder:devfrom
octo-patch:octo/20260823-music-generation-recvsf4VGQpexP

Conversation

@octo-patch

Copy link
Copy Markdown

Reason: Add the requested music generation support.

Summary

  • Update MiniMax music generation handling.
  • Preserve provider-specific request and response behavior.

Validation

@clark-cant clark-cant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

This focused MiniMax update moves the defaults to music-3.0 and adds response decoding coverage. The scope is small, but the asynchronous response path is not complete.

Important — handle in-progress responses instead of treating them as terminal failures

data.status == 1 is now returned as MiniMax music generation is still in progress, but the provider does not retain a task/job identifier or poll the provider before failing. For an asynchronous generation request this makes a normal accepted/in-progress response an unavoidable user-visible failure; the new test locks that failure in as expected behavior.

Please implement the documented completion flow (capture the task identifier and poll/retry until success/cancellation/context deadline), or confirm with an API fixture that this endpoint is synchronous and cannot return status 1 for a valid request. Add coverage for the eventual-success path.

Verdict: Request changes — the async lifecycle must be handled before this can reliably serve music generation.

Posted by github-maintain at 2026-08-24T08:24:34Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants