feat(config): add GOCLAW_CRON_JOB_TIMEOUT env var override - #1114
feat(config): add GOCLAW_CRON_JOB_TIMEOUT env var override#1114nguyennguyenit wants to merge 1 commit into
Conversation
Closes #1098. Aligns with existing GOCLAW_* env-var convention so deployments can override cron.job_timeout without modifying config files.
|
Backlog triage note: this is the cleaner merge candidate for GOCLAW_CRON_JOB_TIMEOUT / #1098, but #1099 contains useful env override tests that this PR does not include. Recommended next step before merge: add equivalent tests here or explicitly decide the duplicate test coverage is not needed, then #1099 can be closed. |
|
Cron-safe maintainer check: this is a tiny, clean implementation for #1098 and CI is green, but I am not merging it yet because duplicate PR #1099 already carries useful |
mrgoonie
left a comment
There was a problem hiding this comment.
Summary: This is the right underlying config change, but this PR should not be the merge target as-is because it duplicates the older, more complete PR #1099 for the same issue #1098.
Risk level: Low
Mandatory gates:
- Duplicate/prior implementation: duplicate found — #1099 already implements GOCLAW_CRON_JOB_TIMEOUT for #1098 and includes focused config-load tests.
- Project standards: issue found — this PR adds the env mapping but no regression test for env override precedence or duration fallback behavior.
- Strategic necessity: clear value, but should be consolidated into one PR.
- CI/checks: green
Findings:
- Important: Please coordinate with #1099 or close this PR in favor of it. #1099 covers the same env var mapping and also adds tests for env override, invalid duration fallback, unset default, and env-over-file precedence. Keeping two open PRs for the same one-line config surface creates duplicate review/merge risk.
- Important: If this PR remains the chosen successor, add equivalent tests in internal/config/config_load_test.go before re-review.
Verdict: REQUEST_CHANGES
Next step: either close this PR in favor of #1099, or explicitly supersede #1099 and bring over the regression tests.
Summary
GOCLAW_CRON_JOB_TIMEOUTenv var to overridecron.job_timeoutfrom config file.GOCLAW_*env var convention.Closes #1098.
Test plan
go build ./...go test ./internal/config/...GOCLAW_CRON_JOB_TIMEOUT=1h ./goclawoverrides default 10m at runtime.