[stable32] Fix(files): Update sidebar on node rename

[marcelklehr]

• Resolves: [Bug]: Renaming a file does not update an opened sidebar [fixed in NC33] #51408

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[szaimen]

🐘

[AndyScherzinger]

/compile

[AndyScherzinger]

/compile rebase

[marcelklehr]

@susnux Do I need to touch the cypress tests for this to pass?

[susnux]

Do I need to touch the cypress tests for this to pass?

Normally not, the failing tests indicate that the behavior here has a real regression.
When you work on a node it seems the sidebar now closes and reopens during that and that's pretty bad if you e.g. update a share.

[susnux]

Locally I cannot spot any issue using the sidebar, maybe you can try running cypress locally to spot the point it fails

[AndyScherzinger]

/compile

[marcelklehr]

mh. It seems to fail to create a directory in a before hook:

  files_sharing: Public share - renaming files
    (Attempt 1 of 3) can rename a file
    (Attempt 2 of 3) can rename a file
    1) "before each" hook for "can rename a file"


  0 passing (22s)
  1 failing

  1) files_sharing: Public share - renaming files
       "before each" hook for "can rename a file":
     Error: Unable to create directory

In my local setup I can't get cypress to run stable32 correctly. It always starts with installing 33.0.0 dev.

I'm somewhat out of depth as I have never run server cypress tests manually.

[susnux]

npm ci
npm run dev
npm run cypress:gui

The tests are related, as soon as the node is updated the sidebar closes and reopens.
But this will also close all open menus inside the sidebar.
E.g. if you create a share the node is updated, but you want to update some of its attributes -> the sidebar quickly close-reopens and now the permissions menu is closed as the component was unmounted for a moment.

The active fileinfo in the sidebar needs to be replaced without closing the sidebar itself.

Bildschirmaufnahme_20260128_140907.webm

[marcelklehr]

And how do you explain Error: Unable to create directory?

[marcelklehr]

I did

npm ci
npm run build
npm run cypress:gui

and couldn't get nextcloud to work because it was telling me I couldn't downgrade from 33.0.0 dev to 32

[susnux]

Maybe only the tests need to be adjusted - it seems like most of the failing use a share cypress helper to create shares.
They:

1. open side bar
2. create share
3. open again
4. open share details
5. adjust share

when 4 is triggered the sidebar is still open with the share details. Then the re-open (either 3 or from your changes) happen and the share details are closed, now 5 fails.

---

So either this happens because of the close+reopen added in this pr or because of the reopen inside the test.
But it is not failing on stable32 so I guess its because of the close + reopen

So my guess still holds:

• "Save" will emit a node updated event for the new share
• you close the sidebar in the listener
• the sharing tab will close the editing mode
• you reopen the sidebar
• the sharing tab now is in overview mode not editing.