Open
Conversation
pci2676
requested changes
Apr 22, 2025
|
|
||
| public static void main(String[] args) { | ||
|
|
||
| String[] names = InputView.inputNames(); |
|
|
||
| String[] names = InputView.inputNames(); | ||
|
|
||
| int ladderHeight = InputView.inputLadderHeight(); |
|
|
||
| int ladderHeight = InputView.inputLadderHeight(); | ||
|
|
||
| LinkedList<Line> lines = new LinkedList<>(); |
There was a problem hiding this comment.
line의 타입을 LinkedList라고 명시적으로 노출해야하는 이유가 있을까요?
| @@ -0,0 +1,19 @@ | |||
| package nextstep.util; | |||
|
|
|||
| public class StringUtils { | |||
There was a problem hiding this comment.
모든 유틸성 코드는 제거하고 책임을 부여한 객체를 활용해보면 좋을것 같습니다.
Comment on lines
+25
to
+29
| public Line(Line previousLine) { | ||
| for (Boolean hasPoint : previousLine.getPoints()) { | ||
| points.add(!hasPoint && RandomUtils.nextBoolean()); | ||
| } | ||
| } |
|
테스트 코드가 없는것 같습니다. 테스트 코드 작성후 요청부탁드립니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.