Conversation
Jegp
reviewed
Aug 27, 2026
Jegp
left a comment
Jegp
left a comment
Collaborator
There was a problem hiding this comment.
Nice changes. I wonder whether it makes sense to somehow model the relationship between the NIRData object on-par with NIR native objects. See my comment here: neuromorphs/NIR#194
| import nir | ||
| from nirtorch import from_nir_data, to_nir_data | ||
| import numpy as np | ||
| import torch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR I propose to add NIRData conversion functionalities to the NIRTorch repo. For many PyTorch-based simulators, the data format does not differ much and they are typically already depending on NIRTorch. Therefore I think it is sensible to add this here. Flexibility is kept by exposing the NIRData API (e.g.
dynamic_before_transitionordt)dtis in units of seconds for NIRData but some simulators may operate in milliseconds, why I added thetime_unitargument. Of course one could just convertdtaccordingly but this might be a nicer way of doing it. But no hard opinions there.This PR depends on the most recent NIR PR.