Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 90.28% 83.78% -6.50%
==========================================
Files 54 54
Lines 4424 4435 +11
==========================================
- Hits 3994 3716 -278
- Misses 430 719 +289 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file and folder names read from central storage were interpolated into the rclone command string that runs through a shell script, so a name with shell metacharacters could execute during a transfer, and a name containing rclone glob characters (
[ ] * ? { }) was treated as a pattern and silently skipped while the transfer still reported successthis routes the include patterns through an
--include-fromfile instead of the command string, and escapes glob characters so names are matched literally. names no longer reach the shell, and files whose names contain glob characters are transferred instead of silently droppedverified against rclone 1.75, existing transfer and logging tests pass