Skip to content

pass rclone transfer includes through a file and escape glob characters - #749

Open
knQzx wants to merge 1 commit into
neuroinformatics-unit:mainfrom
knQzx:fix/rclone-include-escaping
Open

knQzx wants to merge 1 commit into
neuroinformatics-unit:mainfrom
knQzx:fix/rclone-include-escaping

Conversation

@knQzx

@knQzx knQzx commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

file and folder names read from central storage were interpolated into the rclone command string that runs through a shell script, so a name with shell metacharacters could execute during a transfer, and a name containing rclone glob characters ([ ] * ? { }) was treated as a pattern and silently skipped while the transfer still reported success

this routes the include patterns through an --include-from file instead of the command string, and escapes glob characters so names are matched literally. names no longer reach the shell, and files whose names contain glob characters are transferred instead of silently dropped

verified against rclone 1.75, existing transfer and logging tests pass

@codecov

codecov Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.78%. Comparing base (24b4ca0) to head (4d14935).

❗ There is a different number of reports uploaded between BASE (24b4ca0) and HEAD (4d14935). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (24b4ca0) HEAD (4d14935)
34 6
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
- Coverage   90.28%   83.78%   -6.50%     
==========================================
  Files          54       54              
  Lines        4424     4435      +11     
==========================================
- Hits         3994     3716     -278     
- Misses        430      719     +289     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant