Distribute windows - #744
Open
JoeZiminski wants to merge 53 commits into
Open
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…s-unit/datashuttle into cross-platform-packaging
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # break the filename <-> download-link match. | ||
| fetch-depth: 0 | ||
| - name: Set up Conda | ||
| uses: conda-incubator/setup-miniconda@v4 |
| startsWith(github.ref, 'refs/tags/v') || | ||
| (github.event_name == 'workflow_dispatch' && | ||
| inputs.test_release_upload) | ||
| uses: softprops/action-gh-release@v2 |
| ) | ||
| else: | ||
| output = subprocess.run(command, shell=True) | ||
| output = subprocess.run(format_command, shell=True) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
- Coverage 90.28% 90.10% -0.18%
==========================================
Files 54 54
Lines 4424 4445 +21
==========================================
+ Hits 3994 4005 +11
- Misses 430 440 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is #587 but with the windows release only. Troubleshooting the release process will require making actual releases and changing the live docs, so it makes sense to keep it as simple as possible. The macOS release is more complex as it requires code signing and separate builds for intel and arm.
When the macOS release is made, the relevant files should be added back on top of this PR rather than re-split from #587.