Fixes #417: Fix missing Description filter for Access Lists - #424
Merged
Merged
Conversation
AccessListFilterForm named description in its ACL Details fieldset without declaring the field, so NetBox dropped it silently and the filter was unreachable from the UI. Wires FilterFormFieldsetTestMixin to AccessListFormTestCase, the regression guard the other three form test cases already carry. Fixes #417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Fixes #417
New Behavior
Adds the missing Description field to the Access List filter form, making the existing description filter available through the UI.
The Access List form tests now also use
FilterFormFieldsetTestMixinto verify that every field referenced by a fieldset is declared on the form.Contrast to Current Behavior
Previously,
descriptionwas listed in the ACL Details fieldset without a corresponding form field. NetBox therefore omitted it silently, leaving the filter inaccessible from the UI.Discussion: Benefits and Drawbacks
This restores the expected Description filter and adds the same regression protection already used by the other filter form test cases.
The change is backwards-compatible and has no known drawbacks.
Changes to the Documentation
No documentation changes are required.
Proposed Release Note Entry
Fix missing Description field in the Access List filter form.
Double Check
feature(next minor release).