Spec pointer to have better support for omit empty#7
Spec pointer to have better support for omit empty#7henderiw wants to merge 5 commits intonephio-project:mainfrom
Conversation
|
Hi @henderiw. Thanks for your PR. I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
johnbelamaric
left a comment
johnbelamaric
left a comment
There was a problem hiding this comment.
This seems to be the complete files again, it's hard to review. It would be best if you can rebase so we only see the pointer changes
|
Looks like a rebase is needed |
henderiw
force-pushed
the
capacity-pointer
branch
from
51e35de to
5072553
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: henderiw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: henderiw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
gvbalaji
left a comment
gvbalaji
left a comment
There was a problem hiding this comment.
We can do away with some of the getters but no harm. Aked a question on MaxNFConnections, other than that
/approve.
|
rebase needed |
3 participants
using pointer for empty values instead of using default go values.