Update documentation and tests on updating Content-Type#150
Update documentation and tests on updating Content-Type#150thiagodasilva wants to merge 2 commits intoncw:masterfrom
Conversation
Newer swift no longer requires a copy in place to update content-type. Updated a bit of the docs and added test to demonstrate the differences in behavior when using ObjectUpdateContentType and ObjectUpdate to update Content-Type Signed-off-by: Thiago da Silva <[email protected]>
|
This code looks nice too! However we have problems running the tests on older swift versions - any ideas? |
|
I think in this case, there's an issue with the swift emulator, here: It's always adding new custom metadata to an object, when in fact, whenever you post to an object, the previous custom headers are lost. This has always been the swift behavior. I'm adding a new test to clearly show the functionality. |
When posting new custom metadata, the previous custom metadata is lost.
|
Looks like we are going to need a fix to the emulator to get this to pass the tests! Are you working on that? |
|
@ncw I haven't looked at fixing the emulator yet. Having said that, would you consider running the travis ci tests against a docker saio image? I think it would make more sense that maintaining a swift emulator, thoughts? |
I think I'd like to do both - fix the emulator and run against the swift aio! |
2 participants
Newer swift no longer requires a copy in place to update content-type.
Updated a bit of the docs and added test to demonstrate the
differences in behavior when using ObjectUpdateContentType and
ObjectUpdate to update Content-Type
Signed-off-by: Thiago da Silva [email protected]