Skip to content

Make VLBI frame rotation work correctly when proper motion is present #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhisrkckl wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Make VLBI frame rotation work correctly when proper motion is present #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,5 @@ the released changes.
- Fixed bug in `model.compare()` where it failed for `PosixPath` objects
- Fixed bug in printing of parameter correlation/covariance matrices
- `make_fake_toas_fromMJDs` now does not assume `PLANET_SHAPIRO` is in the model - it checks.
- Make VLBI frame rotation work correctly when proper motion is present.
### Removed
2 changes: 1 addition & 1 deletion src/pint/models/astrometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ def ssb_to_psb_xyz_ICRS(self, epoch: Optional[time_like] = None) -> u.Quantity:
# Reference: Madison+ 2023, The Astrophysical Journal 777 104 (Equations 9, 10)
Omega = self.vlbi_coord_rotation()
Khat = self.xyz_from_radec(ra, dec)
result = Omega @ Khat if Omega is not None else Khat
result = (Omega @ Khat.T).T if Omega is not None else Khat
if self.use_ssb_cache:
self._ssb_cache_icrs = result.copy()
self._ssb_cache_key_icrs = key
Expand Down
2 changes: 2 additions & 0 deletions tests/test_vlbi_rotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
PSR VLBITEST1
RAJ 05:00:00 1
DECJ 15:00:00 1
PMRA 1e-6
PMDEC 1e-6
POSEPOCH 55000
VLBIAX -0.15
VLBIAY 0.05
Expand Down
Loading