Open
Conversation
Support for Python 3.12
This updated version of LDAP fixes an issue in NTLM handling where MD4 may not be available already on the system. If this was the case it would try to load the MD4 module from Crypto which is a dependency we did not have installed. This version will load MD4 from Cryptodome, which we are already installing in memory
Non-standard file, its not there in the ldap3 repo currently, but I'm unsure if it is expected by this application
ldap3 was failing to import due to missing winkerberos or gssapi. gssapi would not need to be build for the specific arch, but would require a dependency of MIT Kerberos
need 3 - not 2
Owner
|
Hi, thanks a lot for you PR. Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added dependencies required for BloodHound to utilize Kerberos.
Fixed an issue in the version of ldap3 that was zipped in the repo that occurred in NTLM handling when MD4 is not already available on the system. If this was the case, ldap3 would try to load the MD4 module from Crypto which is a dependency we did not have. The adjusted version will load MD4 from Cryptodome, which we are already have. This is a known and supported fix as per cannatag/ldap3#1051