fix(synchronizer): reconcile deployments with new correlation IDs - #693
Merged
Conversation
Status subresources (introduced in liberator [bacd0593](nais/liberator@bacd0593)) now preserve synchronization status when deployd updates a resource. This caused unchanged redeployments to be no-ops. Include deployd's new correlation ID in the no-op predicate so each deployment triggers reconciliation, even when the spec, image and synchronization hash are unchanged. This replaces the synthetic completion event introduced in `786b92a8`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status subresources (introduced in liberator bacd0593) now preserve synchronization status when deployd updates a resource. This caused unchanged redeployments to be no-ops.
Include deployd's new correlation ID in the no-op predicate so each deployment triggers reconciliation, even when the spec, image and synchronization hash are unchanged.
This replaces the synthetic completion event introduced in 786b92a.