refactor: cleanups - #104
Merged
Merged
Conversation
Frando
force-pushed
the
Frando/cleanups
branch
from
August 17, 2026 12:59
48598ce to
667fffd
Compare
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-services/pr/104/docs/iroh_services/ Last updated: 2026-08-19T12:36:26Z |
| } | ||
| ClientActorMessage::SetAttributes { attributes, done } => { | ||
| let res = self.send_set_attributes(attributes).await; | ||
| if let Err(err) = done.send(res) { |
Contributor
There was a problem hiding this comment.
huh, don't we loose logging for all these error cases now?
Member
Author
There was a problem hiding this comment.
done is the oneshot sender for the reply channel. It errors if the receiver was dropped, which is not an error, just a dropped future on the caller side. The actual errors are propagated throuh done. Dropping the future of eg. Client::push_metrics is not something we should warn-log IMO, it is just allowed behavior.
dignifiedquire
approved these changes
Aug 19, 2026
Frando
force-pushed
the
fix/metrics-reconnect-schema
branch
from
August 19, 2026 11:16
6fb9756 to
9250399
Compare
Frando
force-pushed
the
Frando/cleanups
branch
from
August 19, 2026 12:12
667fffd to
7c99243
Compare
Frando
force-pushed
the
Frando/cleanups
branch
from
August 19, 2026 12:35
7c99243 to
41e1e36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on #101.
This has a few cleanups in the client module, no functional changes.
Othervariants._innerfunctions for no reasonBreaking Changes
Notes & open questions
Change checklist