Repository navigation
Add catch2 2.13.10 as a source dependency - #53
Open
luapmartin wants to merge 1 commit into
Open
luapmartin wants to merge 1 commit into
luapmartin wants to merge 1 commit into
Conversation
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Catch2 2.13.10 (the last Catch2 v2, single header, target
Catch2::Catch2) as a source dependency, for the Audacity AU3 libraries' unit tests (audacity/audacity#12356). Audacity 3 used Catch2 2.13.8; its tests include<catch2/catch.hpp>andCatch2Main.cppdefinesCATCH_CONFIG_MAIN, so v2 is the drop-in choice; a move to v3 can come with a port of the tests.catch2_add_to_build()adds the source tree with the self-tests, docs install, helpers install and-Werroroff. Catch2 2.x still declarescmake_minimum_required(3.5), so the function setsCMAKE_POLICY_DEFAULT_CMP0077to NEW for those variables to win over itsoption()defaults.Consumer side (Audacity, follow-up PR):
require_source_dep(catch2)underMUSE_ENABLE_UNIT_TESTSandcatch2_add_to_build()before the AU3 libraries.Verified by configuring and building Audacity with unit tests on, where 12 Catch2 test executables build and pass.
Assisted by Claude Code (Claude Fable 5.1).