Repository navigation
crashpad_client: add missing <cstdint> for gcc-16 - #50
Merged
Merged
Conversation
This was referenced Sep 16, 2026
Eism
approved these changes
Sep 17, 2026
luapmartin
force-pushed
the
fix-crashpad-cstdint-gcc16
branch
from
September 17, 2026 07:53
f13eae6 to
84cc5a9
Compare
filesystem.h uses uint64_t without including it, relying on transitive inclusion via <time.h>/other headers that gcc-16's stricter libstdc++ header pruning removed.
luapmartin
force-pushed
the
fix-crashpad-cstdint-gcc16
branch
from
September 17, 2026 08:42
84cc5a9 to
69cc521
Compare
kryksyh
approved these changes
Sep 17, 2026
luapmartin
added a commit
to audacity/audacity
that referenced
this pull request
Sep 30, 2026
Resolves: part of #12247 — complements #12189 Unity ON has two real failures in `src/`: - `nyquistpromptloader.cpp`: missing includes for `NyquistPromptEffect`, `NyquistPromptViewModelFactory`, `QQmlEngine`/`QJSEngine`, `au3::wxToString` - `themespagemodel.h`: missing `translation.h` for `muse::qtrc` _(A separate, unrelated gcc-16 failure in vendored `crashpad_client` is fixed in musescore/muse_deps#50.)_ - [x] I signed [CLA](https://www.audacityteam.org/cla/) - [ ] This PR includes AI assistance - [ ] If the PR is AI-assisted, I have read, understood and complied with the [guidelines for AI-assisted contributions](https://github.com/audacity/audacity/blob/master/AI_POLICY.md) - [x] The title of the pull request describes an issue it addresses - [x] If changes are extensive, then there is a sequence of easily reviewable commits - [x] Each commit's message describes its purpose and effects - [x] There are no behavior changes unnecessary for the stated purpose of the PR Recommended: - [x] Each commit compiles and runs on my machine without known undesirable changes of behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to audacity/audacity#12178 (gcc-16 header fixes for Audacity's own src/). While verifying that PR I found this separate gcc-16 failure in the vendored crashpad_client dependency:
filesystem.husesuint64_twithout including<cstdint>, relying on transitive inclusion that gcc-16's stricter libstdc++ header pruning removed - same class of fix asnyquist's existing0026-...-use-cstdint-instead-of-manually-defining.patchanddump_syms's0001-memory-allocator-needs-cstddef.patch.Verified: with this patch,
gcrashpadbuilds clean under gcc-16 (0 errors, full link). Without it,ninja gcrashpadfails exactly as above.gcrashpadfrom scratch (patch applied via the realDEP_PATCHESpipeline, not a manual edit) with gcc-16.0.1 in a Linux containerUpstream: reported at https://issues.chromium.org/issues/562705535 (crashpad
mainstill lacks the include). Sentry carries the same one-liner: getsentry/crashpad@bd3f93d. The patch follows Chromium include order so it matches what would land upstream.