Skip to content

[code-infra] Remove redundant only-allow preinstall hook - #426

Draft
Janpot wants to merge 1 commit into
masterfrom
remove-only-allow
Draft

[code-infra] Remove redundant only-allow preinstall hook#426
Janpot wants to merge 1 commit into
masterfrom
remove-only-allow

Conversation

@Janpot

@Janpot Janpot commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Same as mui/material-ui#49519. Removes "preinstall": "npx only-allow pnpm". It adds nothing:

  • pnpm is already pinned by packageManager and engines.pnpm.
  • npm fails on the root workspace: dependencies (EUNSUPPORTEDPROTOCOL) before the root preinstall runs, so the check never runs.
  • Yarn through Corepack stops right away because of packageManager.

The hook also downloads only-allow with npx outside the lockfile.

@Janpot Janpot added internal Behind-the-scenes enhancement. Formerly called “core”. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). labels Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Janpot