Skip to content

2.3.11 Hotfix Release Candidate - #941

Merged
maxxcrawford merged 4 commits into
2.3.10-hotfixfrom
threads-url
Jul 6, 2023
Merged

2.3.11 Hotfix Release Candidate #941
maxxcrawford merged 4 commits into
2.3.10-hotfixfrom
threads-url

Conversation

@maxxcrawford

@maxxcrawford maxxcrawford commented Jul 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Add Threads.net URL
  • Update release number
  • Fix test issues

@maxxcrawford maxxcrawford changed the title threads url 2.3.11 Hotfix Release Candidate Jul 6, 2023
@maxxcrawford
maxxcrawford marked this pull request as ready for review July 6, 2023 18:26
@maxxcrawford
maxxcrawford requested a review from groovecoder July 6, 2023 18:27
@maxxcrawford

maxxcrawford commented Jul 6, 2023

Copy link
Copy Markdown
Collaborator Author

Note - There's no config.yml for CircleCI pipeline so it "fails" 🤝 (In progress PR #933)

@maxxcrawford
maxxcrawford merged commit 90215c3 into 2.3.10-hotfix Jul 6, 2023
@groovecoder

groovecoder commented Jul 6, 2023

Copy link
Copy Markdown
Member

Code looks good. Spot-check works. Testing without nyc passes:

> mocha --reporter=progress test/setup.js test/features/*.test.js --watch



  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬]

  34 passing (3s)

@groovecoder
groovecoder deleted the threads-url branch July 6, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@groovecoder groovecoder groovecoder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxxcrawford @groovecoder