chore(dashboard): remove the "Make an alias" button from model details - #522
Conversation
GitHub Actions
Inactive
|
Warning Review limit reached
Next review available in: 30 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (20)
WalkthroughChangesThe dashboard removes model alias creation navigation, adds bundled Dashboard update
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
"Alias" is deprecated terminology, and the model detail panel did not need a shortcut into the Routing page: the panel is about a model's pricing and specs, and routing is managed on its own page. Removing the button leaves the panel's onMakeAlias prop, the ModelsPage useNavigate hook, and the react-router import unused, so those go too. The Routing page keeps honoring ?target=provider:model as a deep link, since that is a valid URL entry point independent of the button; only its comment naming the button is updated. Rebuilds the committed dashboard bundle. Every chunk filename changes because the shared index chunk's content hash shifted and cascaded through the import graph; chunk contents are otherwise unchanged.
3588317 to
3d24bd4
Compare
GitHub Actions
Failure
1 participant
Description
Removes the "Make an alias" button from the model detail panel on the Models page. "Alias" is deprecated terminology, and the panel did not need a shortcut into the Routing page: the panel is about a model's pricing and specs, and routing is managed on its own page.
The button was the only in-app source of the Routing page's
?target=provider:modeldeep link, but that link stays supported since it is a valid URL entry point on its own. Only the comment naming the button changed there.Source diff is 3 lines added, 10 removed across two files. The rest of the diff is the rebuilt dashboard bundle, which is committed. Every chunk filename changes because the shared
index-*.jscontent hash shifted and cascaded through the import graph; chunk contents are otherwise unchanged (verified by diffing a sample chunk against the previous bundle).PR Type
Relevant issues
None; requested directly.
Checklist
tests/unit,tests/integration). Deliberately skipped: the change only deletes a UI affordance and its dead props, and a test asserting a button's absence is not worth carrying.make lint,make typecheck,npm --prefix web run typecheck,npm --prefix web test,npm --prefix web run build).uv run python scripts/generate_openapi.py). No API change, so nothing to regenerate.AI Usage
AI Model/Tool used:
Claude Opus 5 via Claude Code.
Any additional AI details you'd like to share:
Claude made the edit and ran the checks; the decision to remove the button and to skip a test for it was @njbrake's.
NOTE:
When responding to reviewer questions, please respond yourself rather than copy/pasting reviewer comments into an AI and pasting back its answer. We want to discuss with you, not your AI :)
Summary
?target=provider:modelprefilling.This keeps routing management on the Routing page and removes deprecated alias terminology.
Technical notes