test: assert the channel-link contract once instead of four times

[njbrake]

Description

Fifth of six stacked PRs. Targets #1553.

Telegram, Linq, BlueBubbles, and Twilio expose the same GET / PUT / DELETE contract over one identifier. test_channels_router.py spelled all of it out four times: 61 test functions, of which 36 were the same nine tests with a different path and field name.

The shared contract is now one class parametrized over the four channels. Each channel keeps a class for its own format rules: numeric ids for Telegram, E.164 for Linq and Twilio, E.164 or an iCloud email for BlueBubbles. ids=str keeps failure attribution per channel.

Same 61 cases collected, 338 fewer lines, and two assertions gained: Telegram, Linq, and BlueBubbles pick up the connected is True check on a linked GET that only Twilio had, and Twilio's remove-when-not-linked test picks up the null-identifier check the other three had.

CHANNEL_CASES is the only roster of link-capable channels, so a channel added to the router and not to the table would ship with no contract coverage and a green build. One test compares the table against the router's own link endpoints.

Type

• Test

Checklist

• Tests pass (uv run pytest -v): 4268 passed, 6 skipped
• Lint passes (ruff check backend/ && ruff format --check backend/)
• New tests added for new functionality: the roster guard
• Bug fixes include regression tests

AI Usage

• AI-assisted: written by Claude Opus 5 via back-and-forth with @njbrake.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: mozilla-ai/clawbolt/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b6fec48e-b2d1-4e1d-a814-d9506230ca66

📥 Commits

Reviewing files that changed from the base of the PR and between 4e3f1d0 and a7a7a6f.

📒 Files selected for processing (1)

• tests/multi_user/test_channels_router.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}