Repository navigation
Match link labels with Unicode case folding - #153
Merged
Merged
Conversation
Link labels were only lowercased for ASCII. The spec matches labels after Unicode case folding, so [ΑΓΩ] must match [αγω] and [ẞ] must match [SS] (spec examples 206 and 540).
This was referenced Oct 1, 2026
Contributor
Author
|
Automated review: Codex CLI ( Verdict: signed off, no changes requested.
Codex could not run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #152.
Bug: link labels were only lowercased for ASCII. The spec matches labels after Unicode case folding.
Repro:
gave
<p>[αγω]</p>instead of a link. Same for[ẞ]vs[SS]: /url.Fix:
link_labelcase-folds the normalized label with@casefold.casefold(full Unicode case folding;moonbit-community/casefoldis already a module dependency, now imported bycmark_base).Spec examples fixed: 206, 540.
Tests:
src/cmark_html/link_label_casefold_test.mbt.Depends on: nothing, independent of the other PRs.