-
Notifications
You must be signed in to change notification settings - Fork 537
Fix message producer defaults for 4.4+ #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix message producer defaults for 4.4+ #1442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates documentation for Moodle's message API to reflect changes made in version 4.4+, where deprecated constants MESSAGE_DEFAULT_LOGGEDIN and MESSAGE_DEFAULT_LOGGEDOFF were replaced with MESSAGE_DEFAULT_ENABLED.
- Updates code examples to use the new
MESSAGE_DEFAULT_ENABLEDconstant instead of the deprecated ones - Updates documentation comments to reflect the simplified bit usage pattern
- Applies these changes consistently across multiple documentation versions (4.4, 4.5, 5.0, and current docs)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/apis/core/message/index.md | Updates current documentation with new constant usage |
| versioned_docs/version-5.0/apis/core/message/index.md | Updates version 5.0 documentation with new constant usage |
| versioned_docs/version-4.5/apis/core/message/index.md | Updates version 4.5 documentation with new constant usage |
| versioned_docs/version-4.4/apis/core/message/index.md | Updates version 4.4 documentation with new constant usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@crazyserver can you review this? It's related to https://moodle.atlassian.net/browse/MDL-67853 |
d3ea5b7 to
2c7a30f
Compare
2c7a30f to
7d9168b
Compare
|
Added change to the 5.1 page. |
Related to https://moodle.atlassian.net/browse/MDL-73284 where
MESSAGE_DEFAULT_LOGGEDOFF / MESSAGE_DEFAULT_LOGGEDINwas removed the docs still use that in docs and not the replacement.