-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(NODE-7122): exponential backoff between retries in convenient transaction API #4765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+187
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/integration/transactions-convenient-api/transactions-convenient-api.prose.test.ts
Outdated
Show resolved
Hide resolved
4073776 to
3dad6c2
Compare
baileympearson
commented
Nov 25, 2025
durran
previously requested changes
Nov 26, 2025
test/integration/transactions-convenient-api/transactions-convenient-api.prose.test.ts
Show resolved
Hide resolved
PavelSafronov
previously approved these changes
Dec 1, 2025
dariakp
requested changes
Dec 3, 2025
test/integration/transactions-convenient-api/transactions-convenient-api.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/transactions-convenient-api/transactions-convenient-api.prose.test.ts
Show resolved
Hide resolved
test/integration/transactions-convenient-api/transactions-convenient-api.prose.test.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@dariakp Comments addressed. Sorry about the rebase + force push, force of habit 😅. |
dariakp
previously requested changes
Dec 3, 2025
test/integration/transactions-convenient-api/transactions-convenient-api.prose.test.ts
Show resolved
Hide resolved
PavelSafronov
previously approved these changes
Dec 10, 2025
Contributor
PavelSafronov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
durran
previously approved these changes
Dec 16, 2025
Member
durran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending 1 type in the spec prose.
0668f2a
87ff29e to
0668f2a
Compare
baileympearson
commented
Dec 16, 2025
5 tasks
0668f2a to
b27507d
Compare
durran
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR adds exponential backoff between convenient transaction API failures if the transaction must be restarted. (DRIVERS-1934)
Release Highlight
withTransactionnow applies exponential backoff during transaction retriesThe convenient transaction API now uses exponential backoff between retries if a transaction must be retried. Under scenarios of high server load, this can prevent transaction retry storms.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript