Skip to content

chore(compass-assistant): remove the feature flag for performance insights COMPASS-10146 #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gagik wants to merge 4 commits into
base: main
Choose a base branch
from
+1 −36
Open

chore(compass-assistant): remove the feature flag for performance insights COMPASS-10146 #7671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d41f74d
chore: switch feature flag for performance insights COMPASS-10141
gagik Dec 19, 2025
c63409d
chore: remove the FF
gagik Dec 19, 2025
7dc5448
chore: remove variable
gagik Dec 19, 2025
00b558c
chore: fix test
gagik Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions packages/compass-assistant/src/compass-assistant-provider.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,24 +183,6 @@ describe('useAssistantActions', function () {
},
});

expect(Object.keys(result.current)).to.have.length.greaterThan(0);
expect(result.current.interpretExplainPlan).to.be.a('function');
expect(result.current.interpretConnectionError).to.be.a('function');
expect(result.current.tellMoreAboutInsight).to.be.undefined;
});

it('returns actions when both AI features and assistant flag AND enablePerformanceInsightsEntrypoints are enabled', function () {
const { result } = renderHook(() => useAssistantActions(), {
wrapper: createWrapper(createMockChat({ messages: [] })),
preferences: {
enableAIAssistant: true,
enablePerformanceInsightsEntrypoints: true,
enableGenAIFeatures: true,
enableGenAIFeaturesAtlasOrg: true,
cloudFeatureRolloutAccess: { GEN_AI_COMPASS: true },
},
});

expect(Object.keys(result.current)).to.have.length.greaterThan(0);
expect(result.current.interpretExplainPlan).to.be.a('function');
expect(result.current.interpretConnectionError).to.be.a('function');
Expand Down
7 changes: 1 addition & 6 deletions packages/compass-assistant/src/compass-assistant-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,6 @@ export function useAssistantActions(): AssistantActionsType {
const actions = useContext(AssistantActionsContext);
const isAIFeatureEnabled = useIsAIFeatureEnabled();
const isAssistantFlagEnabled = usePreference('enableAIAssistant');
const isPerformanceInsightEntrypointsEnabled = usePreference(
'enablePerformanceInsightsEntrypoints'
);

if (!isAIFeatureEnabled || !isAssistantFlagEnabled) {
return {
Expand All @@ -150,9 +147,7 @@ export function useAssistantActions(): AssistantActionsType {
return {
interpretExplainPlan,
interpretConnectionError,
tellMoreAboutInsight: isPerformanceInsightEntrypointsEnabled
? tellMoreAboutInsight
: undefined,
tellMoreAboutInsight,
getIsAssistantEnabled: () => true,
};
}
Expand Down
12 changes: 0 additions & 12 deletions packages/compass-preferences-model/src/feature-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,18 +193,6 @@ export const FEATURE_FLAG_DEFINITIONS = [
},
},

/*
* Feature flag for AI Assistant's performance insight entrypoints.
*/
{
name: 'enablePerformanceInsightsEntrypoints',
stage: 'development',
atlasCloudFeatureFlagName: null,
description: {
short: 'Enable the performance insights AI Assistant entrypoints',
},
},

/*
* Feature flag for AI Assistant's tool calling feature.
*/
Expand Down
Loading