Improve KomodoClient experience for URL and Error handling#805
Open
FoxxMD wants to merge 2 commits intomoghtech:mainfrom
Open
Improve KomodoClient experience for URL and Error handling#805FoxxMD wants to merge 2 commits intomoghtech:mainfrom
FoxxMD wants to merge 2 commits intomoghtech:mainfrom
Conversation
Compensate for URLs with trailing slashes when joining api path
* Uses Error Cause for non-komodo errors * Error message is extracted from Serror, if present * Appends trace, if present, to stack string * Exposes response and SError as class fields
Contributor
Author
|
The only thing I haven't accounted for here is if Komodo itself (through Action) expects the rejected object to be structured the old way. If this is the case I can add fields to the class to make its structure mirror the old way so Komodo can handle it without changing any other code. |
Member
|
In |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the developer experience for using the
komodo_clientnpm package:KomodoApiErrorclass extendingError, used for api response rejection instead of plain objectMany third party logging and network-wrapping libraries are used to handling rejected/thrown
Errorinstances, so using a realErrormeans developers and end users get better readability and visibility into errors for free.