let user specify if they want command to be run in shell-mode#1265
Open
ericls wants to merge 2 commits intomoghtech:mainfrom
Open
let user specify if they want command to be run in shell-mode#1265ericls wants to merge 2 commits intomoghtech:mainfrom
ericls wants to merge 2 commits intomoghtech:mainfrom
Conversation
Member
|
Thanks will review |
Contributor
Author
Thanks for Komodo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1217 in v2.
In v2, things are easier because there's an explicit shell-mode. This makes this change easier to implement and won't cause backwards incompitable changes for existing configs.
Makes something like the following possible:
Without this option, scripts like this would fail for reason like:
Would improve #808
closes #1217