-
Notifications
You must be signed in to change notification settings - Fork 177
Clarify file extension and formats #4726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Clarify file extension and formats #4726
Conversation
maltelenz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I object to calling the text file format a Dymola MOS file. Even if Dymola was the first to use it (I assume it was), it has clearly become something tool independent in the decade(s) since then.
|
@maltelenz In a constructive manner, please do not state how to not call
it but how to call it instead. You can directly edit this PR.
Am 2026-01-29 09:06, schrieb Malte Lenz:
… @maltelenz requested changes on this pull request.
I object to calling the text file format a Dymola MOS file. Even if
Dymola was the first to use it (I assume it was), it has clearly become
something tool independent in the decade(s) since then.
|
|
@beutlich Does it need to be called something except |
|
I believe that format precedes my involvement with Dymola, and I'm not even sure if the format is from Dymola or if that text file format for tables is from DLR - possibly as part of ANDECS/DSblock even if we use it in Dymola, can @MartinOtter confirm? It should not be confused with Dymola's script files (mos-files), as they normally have the extension "txt" not "mos". I tried to search our documentation and couldn't find any other name than "text file", except possibly "Matlab text file" - even if it isn't from MathWorks - as it's a text-file with the same structure as Matlab v4 file. |
|
Yes, that is what the issue is about. The term `text format` is
ambiguous since CSV is another `text format`. So better to give this
special format a proper name. `Dymola MOS` is the best thing I came up
so far.
Am 2026-01-29 10:56, schrieb Malte Lenz:
… maltelenz left a comment (modelica/ModelicaStandardLibrary#4726)
@beutlich Does it need to be called something except `text format` like
before?
|
|
Based on some internal discussion it seems it was from DLR, and I would propose to call it "DLR matrix text format" Note that the file extension is usually "txt". |
c84b167 to
2eff2c2
Compare
Thanks. We have a name finally. The PR is revised accordingly. Note, that any file extension is technically legal for the "DLR matrix text format". Only CSV format needs to have .csv extension and MAT-File format needs to have .mat extension. This is also made explicit by this PR. |
Dismissing blocking review as my concern was resolved, and I have no further opinions on the PR.
Closes #4704
See also https://github.com/tbeu/Modelica2021_ExternData/blob/02117c93ee96e6d5a5b1115ded46a83fbaa91c5e/modelica2021_ExternData.tex#L132 on the name "Dymola MOS".