Skip to content

Conversation

@beutlich
Copy link
Member

@beutlich beutlich added this to the MSL4.2.0 milestone Jan 28, 2026
@beutlich beutlich added L: Blocks Issue addresses Modelica.Blocks documentation Issue addresses the documentation labels Jan 28, 2026
Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I object to calling the text file format a Dymola MOS file. Even if Dymola was the first to use it (I assume it was), it has clearly become something tool independent in the decade(s) since then.

@beutlich
Copy link
Member Author

beutlich commented Jan 29, 2026 via email

@maltelenz
Copy link
Contributor

@beutlich Does it need to be called something except text format like before?

@HansOlsson
Copy link
Contributor

HansOlsson commented Jan 29, 2026

I believe that format precedes my involvement with Dymola, and I'm not even sure if the format is from Dymola or if that text file format for tables is from DLR - possibly as part of ANDECS/DSblock even if we use it in Dymola, can @MartinOtter confirm?

It should not be confused with Dymola's script files (mos-files), as they normally have the extension "txt" not "mos".

I tried to search our documentation and couldn't find any other name than "text file", except possibly "Matlab text file" - even if it isn't from MathWorks - as it's a text-file with the same structure as Matlab v4 file.

@beutlich
Copy link
Member Author

beutlich commented Jan 29, 2026 via email

@HansOlsson
Copy link
Contributor

Based on some internal discussion it seems it was from DLR, and I would propose to call it "DLR matrix text format"

Note that the file extension is usually "txt".
It has nothing to do with Dymola's mos-files.

@beutlich beutlich force-pushed the calrify-file-extension-of-tables branch from c84b167 to 2eff2c2 Compare January 29, 2026 16:49
@beutlich
Copy link
Member Author

beutlich commented Jan 29, 2026

Based on some internal discussion it seems it was from DLR, and I would propose to call it "DLR matrix text format"

Note that the file extension is usually "txt". It has nothing to do with Dymola's mos-files.

Thanks. We have a name finally. The PR is revised accordingly. Note, that any file extension is technically legal for the "DLR matrix text format". Only CSV format needs to have .csv extension and MAT-File format needs to have .mat extension. This is also made explicit by this PR.

@maltelenz maltelenz dismissed their stale review January 30, 2026 08:19

Dismissing blocking review as my concern was resolved, and I have no further opinions on the PR.

@beutlich beutlich requested review from HansOlsson and maltelenz and removed request for HansOlsson and maltelenz January 30, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issue addresses the documentation L: Blocks Issue addresses Modelica.Blocks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CombiTables documentation does not report that the .csv file type doesn't require the header

3 participants