Repository navigation
[Capability] Check tool names against the spec's 128-character limit and character set - #639
Open
jaeminbird wants to merge 1 commit into
Open
jaeminbird wants to merge 1 commit into
jaeminbird wants to merge 1 commit into
Conversation
…and character set
jaeminbird
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
October 29, 2026 06:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NameValidatoraccepts 1–64 characters including/, but the spec's "Tool Names" rule (2025-11-25 onward) is 1–128 characters ofA-Z a-z 0-9 _ - ., the same rule the TypeScript SDK uses. So a valid 100-character name logs a warning, whilea/band a name ending in\n($without/D) do not.The regex becomes
/^[a-zA-Z0-9._-]{1,128}$/Dand the warning text is updated. It stays a warning, so registration behaviour doesn't change. In the test,my/toolmoves from valid to invalid, since the spec no longer allows/.my/tool,my_tool\n) fail on main and pass here.