Skip to content

test: cover webview and app install/uninstall on both platforms #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmegidish wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: cover webview and app install/uninstall on both platforms #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e98e825
test: cover webview and app install/uninstall on both platforms
gmegidish Sep 12, 2026
73738cc
test: poll the device instead of sleeping, and address review
gmegidish Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,19 @@ test-cover: build-cover
test-e2e: build-cover
rm -rf test/coverage
mkdir -p test/coverage
# device commands run inside the daemon, so its counters are the bulk of the
# coverage. stop any daemon already running: the suites spawn a fresh one that
# inherits GOCOVERDIR, and a -cover binary only writes counters when it exits.
./mobilecli daemon stop
go test ./... -v -race -covermode=atomic -args -test.gocoverdir=$(CURDIR)/test/coverage
(cd test && npm run test:server)
(cd test && npm run test:daemon)
# (cd test && npm run test:ios)
(cd test && npm run test:simulator)
(cd test && npm run test:android)
# one shell with a trap, so a failing suite still stops the daemon and flushes
# its counters into test/coverage before they are read back
set -e; \
trap 'GOCOVERDIR=$(CURDIR)/test/coverage ./mobilecli daemon stop >/dev/null 2>&1 || true' EXIT; \
(cd test && npm run test:server); \
(cd test && npm run test:daemon); \
(cd test && npm run test:ios-simulator); \
(cd test && npm run test:android); \
(cd test && npm run test:emulator)
go tool covdata textfmt -i=test/coverage -o coverage.out
go tool cover -html=coverage.out -o coverage.html
Expand Down
Loading
Loading