Skip to content

Documentation error? #79

Description

@kshetline

This seems problematic:

const esbuild = require('rollup-plugin-esbuild') // 'rollup-plugin-esbuild' is required
const alias = require('@mnrendra/rollup-plugin-mixexport') // (Optional) to resolve alias paths
const mixexport = require('@mnrendra/rollup-plugin-mixexport')

...since alias and mixexport are identically defined.

Should this be more like:

const esbuild = require('rollup-plugin-esbuild') // 'rollup-plugin-esbuild' is required
const { alias, mixexport } = require('@mnrendra/rollup-plugin-mixexport')

...or...

const esbuild = require('rollup-plugin-esbuild') // 'rollup-plugin-esbuild' is required
const alias = require('@mnrendra/rollup-plugin-alias') // (Optional) to resolve alias paths
const mixexport = require('@mnrendra/rollup-plugin-mixexport')

...?

I can't test either solution myself because I'm not using esbuild in my project and, at least for now, I don't want to modify my build procedure to use esbuild.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions